]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info
authorColin Ian King <colin.king@canonical.com>
Tue, 14 Jan 2020 14:54:48 +0000 (14:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Jan 2020 22:05:54 +0000 (23:05 +0100)
Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
however up to UCC_MAX_NUM (8) elements are potentially being written
to it.  Currently we have an array out-of-bounds write error on the
last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
size.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: 0e2bc9d1ba7f ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/fsl_ucc_hdlc.c

index ca0f3be2b6bf8c4c3c4ed330651dabd8bb756ff8..aef7de225783f6bd19c0ee2d9e52f5a11a7fcf81 100644 (file)
@@ -73,7 +73,7 @@ static struct ucc_tdm_info utdm_primary_info = {
        },
 };
 
-static struct ucc_tdm_info utdm_info[MAX_HDLC_NUM];
+static struct ucc_tdm_info utdm_info[UCC_MAX_NUM];
 
 static int uhdlc_init(struct ucc_hdlc_private *priv)
 {