]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: SOF: amd: Increase ACP_HW_SEM_RETRY_COUNT value
authorAjit Kumar Pandey <AjitKumar.Pandey@amd.com>
Fri, 4 Mar 2022 20:57:30 +0000 (14:57 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 13:12:51 +0000 (13:12 +0000)
Host is trying to acquire semaphore lock based on HW_SEM_RETRY_COUNT
value which is set to 10 by default. So host will loop for 10 times
trying to acquire lock before giving error msg "Failed to acquire HW
lock". Though this loop count of 10 is good enough with most of the
times but we have observed such failure msg in very few cases(~5 %).

Increase ACP_HW_SEM_RETRY_COUNT to avoid such issue and loop for a
significant time period before throwing error. We're setting newer
loop count to quite higher value of 10K but it's very unlikely that
it will loop for this count, since for most of the cases lock will
get acquired at much lesser loop iterations.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220304205733.62233-8-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/amd/acp.h

index db1030d36811dbaa713a18e42bca0a56dbea1877..f550a5010a91e802820e8fc3c55d39368e2df525 100644 (file)
@@ -17,7 +17,7 @@
 
 #define ACP_DSP_BAR    0
 
-#define ACP_HW_SEM_RETRY_COUNT                 10
+#define ACP_HW_SEM_RETRY_COUNT                 10000
 #define ACP_REG_POLL_INTERVAL                   500
 #define ACP_REG_POLL_TIMEOUT_US                 2000
 #define ACP_DMA_COMPLETE_TIMEOUT_US            5000