]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/amd/display: Fix Coverity Issues
authorChris Park <Chris.Park@amd.com>
Thu, 4 Nov 2021 20:52:08 +0000 (16:52 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 17 Nov 2021 21:58:08 +0000 (16:58 -0500)
[Why]
Coverity discovers holes in logic that needs to be addressed for
improved code integrity.

[How]
Address issues found by coverity without changing the actual logic.

Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Chris Park <Chris.Park@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c

index 0321b4446e0563f92f473809ef0d7226396eff1a..2d0f1f4a8fffa85f06f40bf2028919d4058cd2b0 100644 (file)
@@ -574,7 +574,7 @@ static bool decide_dsc_target_bpp_x16(
        return *target_bpp_x16 != 0;
 }
 
-#define MIN_AVAILABLE_SLICES_SIZE  4
+#define MIN_AVAILABLE_SLICES_SIZE  6
 
 static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *available_slices)
 {
@@ -860,6 +860,10 @@ static bool setup_dsc_config(
                min_slices_h = 0; // DSC TODO: Maybe try increasing the number of slices first?
 
        is_dsc_possible = (min_slices_h <= max_slices_h);
+
+       if (min_slices_h == 0 && max_slices_h == 0)
+               is_dsc_possible = false;
+
        if (!is_dsc_possible)
                goto done;