NFSD: Prevent a possible oops in the nfs_dirent() tracepoint

The double copy of the string is a mistake, plus __assign_str()
uses strlen(), which is wrong to do on a string that isn't
guaranteed to be NUL-terminated.

Fixes: 01888e035498 ("NFSD: Add a tracepoint to record directory entry encoding")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
index 10cc3aaf1089e3398b920bc5826865a7259ce558..adaec43548d11f32310bd319d6a195c6f8bbcf33 100644 (file)
--- a/fs/nfsd/trace.h
+++ b/fs/nfsd/trace.h
@@ -408,7 +408,6 @@ TRACE_EVENT(nfsd_dirent,
                __entry->ino = ino;
                __entry->len = namlen;
                memcpy(__get_str(name), name, namlen);
-               __assign_str(name, name);
        ),
        TP_printk("fh_hash=0x%08x ino=%llu name=%.*s",
                __entry->fh_hash, __entry->ino,