ALSA: hda: cs35l41: Remove Set Channel Map api from binding

This API was required for CLSA0100 laptop, which did not
have correct properties inside ACPI. The required values
are now hardcoded inside the driver so this is no longer
needed.
Without this api, there CLSA0100 can now use the generic
cs35l41 fixup, like the other laptops.
All other laptops will read the Speaker Position from
ACPI and set the channel map from within the driver.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220509214703.4482-4-vitalyr@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index d7e90c0cae5132a6a19b092718fb33eaa0cf9899..96c3e541696d8749a3d5f6cdfe02b1c276888009 100644 (file)
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -92,7 +92,6 @@ static int cs35l41_hda_bind(struct device *dev, struct device *master, void *mas
        comps->dev = dev;
        strscpy(comps->name, dev_name(dev), sizeof(comps->name));
        comps->playback_hook = cs35l41_hda_playback_hook;
-       comps->set_channel_map = cs35l41_hda_channel_map;
 
        return 0;
 }

diff --git a/sound/pci/hda/hda_component.h b/sound/pci/hda/hda_component.h
index 2e52be6db9c21d0ef858a1239cbd1f340b70762f..e26c896a13f3469f961fd732c8f6308318d95196 100644 (file)
--- a/sound/pci/hda/hda_component.h
+++ b/sound/pci/hda/hda_component.h
@@ -15,6 +15,4 @@ struct hda_component {
        struct device *dev;
        char name[HDA_MAX_NAME_SIZE];
        void (*playback_hook)(struct device *dev, int action);
-       int (*set_channel_map)(struct device *dev, unsigned int rx_num, unsigned int *rx_slot,
-                               unsigned int tx_num, unsigned int *tx_slot);
 };

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 62fbf3772b4123db475cea1a53797eb05bd87ff5..dc1ff4c542911e6de68dc945af59a7ece6fb6845 100644 (file)
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6582,18 +6582,6 @@ static void alc287_fixup_legion_15imhg05_speakers(struct hda_codec *codec,
        }
 }
 
-static int find_comp_by_dev_name(struct alc_spec *spec, const char *name)
-{
-       int i;
-
-       for (i = 0; i < HDA_MAX_COMPONENTS; i++) {
-               if (strcmp(spec->comps[i].name, name) == 0)
-                       return i;
-       }
-
-       return -ENODEV;
-}
-
 static int comp_bind(struct device *dev)
 {
        struct hda_codec *cdc = dev_to_hda_codec(dev);
@@ -6668,50 +6656,10 @@ static void cs35l41_fixup_spi_four(struct hda_codec *codec, const struct hda_fix
        cs35l41_generic_fixup(codec, action, "spi0", "CSC3551", 4);
 }
 
-static void alc287_legion_16achg6_playback_hook(struct hda_pcm_stream *hinfo, struct hda_codec *cdc,
-                                               struct snd_pcm_substream *sub, int action)
-{
-       struct alc_spec *spec = cdc->spec;
-       unsigned int rx_slot;
-       int i;
-
-       switch (action) {
-       case HDA_GEN_PCM_ACT_PREPARE:
-               rx_slot = 0;
-               i = find_comp_by_dev_name(spec, "i2c-CLSA0100:00-cs35l41-hda.0");
-               if (i >= 0)
-                       spec->comps[i].set_channel_map(spec->comps[i].dev, 0, NULL, 1, &rx_slot);
-
-               rx_slot = 1;
-               i = find_comp_by_dev_name(spec, "i2c-CLSA0100:00-cs35l41-hda.1");
-               if (i >= 0)
-                       spec->comps[i].set_channel_map(spec->comps[i].dev, 0, NULL, 1, &rx_slot);
-               break;
-       }
-
-       comp_generic_playback_hook(hinfo, cdc, sub, action);
-}
-
 static void alc287_fixup_legion_16achg6_speakers(struct hda_codec *cdc, const struct hda_fixup *fix,
                                                 int action)
 {
-       struct device *dev = hda_codec_dev(cdc);
-       struct alc_spec *spec = cdc->spec;
-       int ret;
-
-       switch (action) {
-       case HDA_FIXUP_ACT_PRE_PROBE:
-               component_match_add(dev, &spec->match, component_compare_dev_name,
-                                   "i2c-CLSA0100:00-cs35l41-hda.0");
-               component_match_add(dev, &spec->match, component_compare_dev_name,
-                                   "i2c-CLSA0100:00-cs35l41-hda.1");
-               ret = component_master_add_with_match(dev, &comp_master_ops, spec->match);
-               if (ret)
-                       codec_err(cdc, "Fail to register component aggregator %d\n", ret);
-               else
-                       spec->gen.pcm_playback_hook = alc287_legion_16achg6_playback_hook;
-               break;
-       }
+       cs35l41_generic_fixup(cdc, action, "i2c", "CLSA0100", 2);
 }
 
 /* for alc295_fixup_hp_top_speakers */