]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5e: TC, Remove redundant error logging
authorRoi Dayan <roid@nvidia.com>
Mon, 3 Jan 2022 08:57:01 +0000 (10:57 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 7 Jan 2022 00:22:55 +0000 (16:22 -0800)
Remove redundant and trivial error logging when trying to
offload mirred device with unsupported devices.
Using OVS could hit those a lot and the errors are still
logged in extack.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c

index a0832b86016c0ae50d9723dadc863606a81a1844..c614fc7fdc9c9f632471a4eb22673962a53a925f 100644 (file)
@@ -45,14 +45,10 @@ verify_uplink_forwarding(struct mlx5e_priv *priv,
                                        termination_table_raw_traffic)) {
                NL_SET_ERR_MSG_MOD(extack,
                                   "devices are both uplink, can't offload forwarding");
-                       pr_err("devices %s %s are both uplink, can't offload forwarding\n",
-                              priv->netdev->name, out_dev->name);
                        return -EOPNOTSUPP;
        } else if (out_dev != rep_priv->netdev) {
                NL_SET_ERR_MSG_MOD(extack,
                                   "devices are not the same uplink, can't offload forwarding");
-               pr_err("devices %s %s are both uplink but not the same, can't offload forwarding\n",
-                      priv->netdev->name, out_dev->name);
                return -EOPNOTSUPP;
        }
        return 0;
@@ -160,10 +156,6 @@ tc_act_can_offload_mirred(struct mlx5e_tc_act_parse_state *parse_state,
        }
 
        NL_SET_ERR_MSG_MOD(extack, "devices are not on same switch HW, can't offload forwarding");
-       netdev_warn(priv->netdev,
-                   "devices %s %s not on same switch HW, can't offload forwarding\n",
-                   netdev_name(priv->netdev),
-                   out_dev->name);
 
        return false;
 }