]> git.baikalelectronics.ru Git - kernel.git/commitdiff
mmc: mmci_sdmmc: Replace sg_dma_xxx macros
authorLudovic Barre <ludovic.barre@st.com>
Tue, 28 Jan 2020 09:06:28 +0000 (10:06 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 24 Mar 2020 13:35:40 +0000 (14:35 +0100)
sg_dma_xxx should be used after a dma_map_sg call has been done to get bus
addresses of each of the SG entries and their lengths.  But mmci_host_ops
validate_data can be called before dma_map_sg.  This patch replaces theses
macros by sg->offset and sg->length which are always defined.

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
Link: https://lore.kernel.org/r/20200128090636.13689-2-ludovic.barre@st.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mmci_stm32_sdmmc.c

index a4f7e8e689d3a16190ed67114ce7da06b49766f7..6ccfbbc82c775a02b29fcc5365beaf1e689b8517 100644 (file)
@@ -36,8 +36,8 @@ static int sdmmc_idma_validate_data(struct mmci_host *host,
         * excepted the last element which has no constraint on idmasize
         */
        for_each_sg(data->sg, sg, data->sg_len - 1, i) {
-               if (!IS_ALIGNED(sg_dma_address(data->sg), sizeof(u32)) ||
-                   !IS_ALIGNED(sg_dma_len(data->sg), SDMMC_IDMA_BURST)) {
+               if (!IS_ALIGNED(data->sg->offset, sizeof(u32)) ||
+                   !IS_ALIGNED(data->sg->length, SDMMC_IDMA_BURST)) {
                        dev_err(mmc_dev(host->mmc),
                                "unaligned scatterlist: ofst:%x length:%d\n",
                                data->sg->offset, data->sg->length);
@@ -45,7 +45,7 @@ static int sdmmc_idma_validate_data(struct mmci_host *host,
                }
        }
 
-       if (!IS_ALIGNED(sg_dma_address(data->sg), sizeof(u32))) {
+       if (!IS_ALIGNED(data->sg->offset, sizeof(u32))) {
                dev_err(mmc_dev(host->mmc),
                        "unaligned last scatterlist: ofst:%x length:%d\n",
                        data->sg->offset, data->sg->length);