HID: hyperv: fix possible memory leak in mousevsc_probe()

[ Upstream commit c39bde10c9bfe491248fd5467c3a96a196cfddd3 ]

If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().

Fixes: 4c43162e555f ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 79a28fc9152162c695a05eb55fe989c48f74612d..5928e934d7343810e01bfd1e3dc2febcf93f5b0a 100644 (file)
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -492,7 +492,7 @@ static int mousevsc_probe(struct hv_device *device,
 
        ret = hid_add_device(hid_dev);
        if (ret)
-               goto probe_err1;
+               goto probe_err2;
 
 
        ret = hid_parse(hid_dev);