]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: ethernet: mtk_eth_wed: add missing of_node_put()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 17 Oct 2022 03:51:56 +0000 (11:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Oct 2022 08:35:06 +0000 (09:35 +0100)
The device_node pointer returned by of_parse_phandle() with refcount
incremented, when finish using it, the refcount need be decreased.

Fixes: 7e7e0fcc79f5 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_wed.c

index 09bbd05bd83c1ffe017ef7a3d7a2618c53d657cd..65e01bf4b4d223c295b898ad42ef9e312b57f7c8 100644 (file)
@@ -1072,7 +1072,7 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth,
 
        pdev = of_find_device_by_node(np);
        if (!pdev)
-               return;
+               goto err_of_node_put;
 
        get_device(&pdev->dev);
        irq = platform_get_irq(pdev, 0);
@@ -1132,6 +1132,8 @@ unlock:
        mutex_unlock(&hw_lock);
 err_put_device:
        put_device(&pdev->dev);
+err_of_node_put:
+       of_node_put(np);
 }
 
 void mtk_wed_exit(void)
@@ -1152,6 +1154,7 @@ void mtk_wed_exit(void)
                hw_list[i] = NULL;
                debugfs_remove(hw->debugfs_dir);
                put_device(hw->dev);
+               of_node_put(hw->node);
                kfree(hw);
        }
 }