block: remove superfluous calls to blkcg_bio_issue_init

blkcg_bio_issue_init is called in submit_bio.  There is no need to have
extra calls that just get overriden in __bio_clone and the two places
that copy and pasted from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Link: https://lore.kernel.org/r/20220504142950.567582-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/bio.c b/block/bio.c
index 212ccd5b5212d0d7cd22f807501179900131b6c6..aa94195ffd02270895cb6cdce160daee0e320f00 100644 (file)
--- a/block/bio.c
+++ b/block/bio.c
@@ -768,7 +768,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
        bio->bi_iter = bio_src->bi_iter;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        if (bio_crypt_clone(bio, bio_src, gfp) < 0)
                return -ENOMEM;

diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
index 5d1aa5b1d30a126f2717b619e3077e4ccdc79c50..621abd1b0e4d329655b2ea276bed7005e93522ef 100644 (file)
--- a/block/blk-crypto-fallback.c
+++ b/block/blk-crypto-fallback.c
@@ -179,7 +179,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
                bio->bi_io_vec[bio->bi_vcnt++] = bv;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        return bio;
 }

diff --git a/block/bounce.c b/block/bounce.c
index 467be46d0e65620c08067579ff4fd30f1ce666a6..8f7b6fe3b4db5f621e5efce566ab3e9697b44fd9 100644 (file)
--- a/block/bounce.c
+++ b/block/bounce.c
@@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
                goto err_put;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        return bio;