]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: pcs: xpcs: depends on PHYLINK in Kconfig
authorJakub Kicinski <kuba@kernel.org>
Thu, 23 Jun 2022 20:29:33 +0000 (13:29 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 25 Jun 2022 05:49:22 +0000 (22:49 -0700)
This is yet another attempt at fixing:

>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!

Switch XPCS to be invisible, as Russell points out it's
"selected" by its consumers. Drop the dependency on MDIO_BUS
as "depends" is meaningless on "selected" symbols.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 481730fda404 ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Link: https://lore.kernel.org/netdev/20220620201915.1195280-1-kuba@kernel.org/
Link: https://lore.kernel.org/r/20220622083521.0de3ea5c@kernel.org/
Link: https://lore.kernel.org/r/20220623202933.2341938-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/Kconfig

index 22ba7b0b476d715da794a0d20437f29e87001f78..f778e5155fae2bcb2f07953b3cde4c33efca64f0 100644 (file)
@@ -6,8 +6,8 @@
 menu "PCS device drivers"
 
 config PCS_XPCS
-       tristate "Synopsys DesignWare XPCS controller"
-       depends on MDIO_DEVICE && MDIO_BUS
+       tristate
+       select PHYLINK
        help
          This module provides helper functions for Synopsys DesignWare XPCS
          controllers.