]> git.baikalelectronics.ru Git - kernel.git/commitdiff
block/badblocks: Remove redundant assignments
authorMichal Orzel <michalorzel.eng@gmail.com>
Sat, 23 Apr 2022 11:38:07 +0000 (13:38 +0200)
committerJens Axboe <axboe@kernel.dk>
Sat, 23 Apr 2022 13:15:26 +0000 (07:15 -0600)
Get rid of redundant assignments to a variable sectors from functions
badblocks_check and badblocks_clear. This variable, that is a function
parameter, is being assigned a value that is never read until the end of
function.

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Link: https://lore.kernel.org/r/20220423113811.13335-1-michalorzel.eng@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/badblocks.c

index d39056630d9c1de07d3923daeb8b80e6ab6a086e..3afb550c0f7b782ad9bc95be4a50e111154994ac 100644 (file)
@@ -65,7 +65,6 @@ int badblocks_check(struct badblocks *bb, sector_t s, int sectors,
                s >>= bb->shift;
                target += (1<<bb->shift) - 1;
                target >>= bb->shift;
-               sectors = target - s;
        }
        /* 'target' is now the first block after the bad range */
 
@@ -345,7 +344,6 @@ int badblocks_clear(struct badblocks *bb, sector_t s, int sectors)
                s += (1<<bb->shift) - 1;
                s >>= bb->shift;
                target >>= bb->shift;
-               sectors = target - s;
        }
 
        write_seqlock_irq(&bb->lock);