scsi: aacraid: Fix undefined behavior due to shift overflowing the constant

Fix:

  drivers/scsi/aacraid/commsup.c: In function ‘aac_handle_sa_aif’:
  drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduce to an integer constant
    case SA_AIF_BPCFG_CHANGE:
    ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Link: https://lore.kernel.org/r/20220405151517.29753-2-bp@alien8.de
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index f849e7c9d428e4633e5eea1517e46a106ad8385d..5e115e8b2ba462bae6d821e195a6f9462e10c70f 100644 (file)
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -121,7 +121,7 @@ enum {
 #define SA_AIF_PDEV_CHANGE             (1<<4)
 #define SA_AIF_LDEV_CHANGE             (1<<5)
 #define SA_AIF_BPSTAT_CHANGE           (1<<30)
-#define SA_AIF_BPCFG_CHANGE            (1<<31)
+#define SA_AIF_BPCFG_CHANGE            (1U<<31)
 
 #define HBA_MAX_SG_EMBEDDED            28
 #define HBA_MAX_SG_SEPARATE            90