]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5: Fix format-security build warnings
authorSaeed Mahameed <saeedm@nvidia.com>
Wed, 3 Nov 2021 21:01:05 +0000 (14:01 -0700)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 17 Nov 2021 04:31:47 +0000 (20:31 -0800)
Treat the string as an argument to avoid this.

drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:482:5:
error: format string is not a string literal (potentially insecure)
                         name);
                         ^~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:2079:4:
error: format string is not a string literal (potentially insecure)
                        ptp_ch_stats_desc[i].format);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c

index 2a9bfc3ffa2ec8ba664747f2251b4a818ea03a73..3c91a11e27ad467b0d4500b36f65c400e02a0ac0 100644 (file)
@@ -2076,7 +2076,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STRS(ptp)
 
        for (i = 0; i < NUM_PTP_CH_STATS; i++)
                sprintf(data + (idx++) * ETH_GSTRING_LEN,
-                       ptp_ch_stats_desc[i].format);
+                       "%s", ptp_ch_stats_desc[i].format);
 
        if (priv->tx_ptp_opened) {
                for (tc = 0; tc < priv->max_opened_tc; tc++)
index 830444f927d456deff102c57dc26332bfc124696..19bf2b66707d93a0dbdfe3efed85d00e3cac5af2 100644 (file)
@@ -479,7 +479,7 @@ irq_pool_alloc(struct mlx5_core_dev *dev, int start, int size, char *name,
        pool->xa_num_irqs.max = start + size - 1;
        if (name)
                snprintf(pool->name, MLX5_MAX_IRQ_NAME - MLX5_MAX_IRQ_IDX_CHARS,
-                        name);
+                        "%s", name);
        pool->min_threshold = min_threshold * MLX5_EQ_REFS_PER_IRQ;
        pool->max_threshold = max_threshold * MLX5_EQ_REFS_PER_IRQ;
        mlx5_core_dbg(dev, "pool->name = %s, pool->size = %d, pool->start = %d",