]> git.baikalelectronics.ru Git - kernel.git/commitdiff
iio: imu: fxos8700: fix incomplete ACCEL and MAGN channels readback
authorCarlos Song <carlos.song@nxp.com>
Thu, 8 Dec 2022 07:19:07 +0000 (15:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:28:18 +0000 (11:28 +0100)
commit 37a94d86d7050665d6d01378b2c916c28e454f10 upstream.

The length of ACCEL and MAGN 3-axis channels output data is 6 byte
individually. However block only read 3 bytes data into buffer from
ACCEL or MAGN output data registers every time. It causes an incomplete
ACCEL and MAGN channels readback.

Set correct value count for regmap_bulk_read to get 6 bytes ACCEL and
MAGN channels readback.

Fixes: 2c7e7594a2fd ("iio: imu: Add support for the FXOS8700 IMU")
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Link: https://lore.kernel.org/r/20221208071911.2405922-4-carlos.song@nxp.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/imu/fxos8700_core.c

index d19f47227b5f6d734bf7ba8cef12630b5676dac3..26029510b1e97afdcc8397a6065c715282a38b60 100644 (file)
@@ -425,7 +425,7 @@ static int fxos8700_get_data(struct fxos8700_data *data, int chan_type,
 
        /* Block read 6 bytes of device output registers to avoid data loss */
        ret = regmap_bulk_read(data->regmap, base, data->buf,
-                              FXOS8700_DATA_BUF_SIZE);
+                              sizeof(data->buf));
        if (ret)
                return ret;