]> git.baikalelectronics.ru Git - kernel.git/commitdiff
x86/entry: Change exit path of xen_failsafe_callback
authorThomas Gleixner <tglx@linutronix.de>
Thu, 21 May 2020 20:05:30 +0000 (22:05 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 11 Jun 2020 13:15:10 +0000 (15:15 +0200)
xen_failsafe_callback() is invoked from XEN for two cases:

  1. Fault while reloading DS, ES, FS or GS
  2. Fault while executing IRET

 #1 retries the IRET after XEN has fixed up the segments.
 #2 injects a #GP which kills the task

For #1 there is no reason to go through the full exception return path
because the tasks TIF state is still the same. So just going straight to
the IRET path is good enough.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Andy Lutomirski <luto@kernel.org>
Link: https://lore.kernel.org/r/20200521202118.423224507@linutronix.de
arch/x86/entry/entry_32.S
arch/x86/entry/entry_64.S

index 6c6ae3a8c1fc02e8ac9610563aa165991191f55d..6fcdee9feba0e8025d69c56484dfdc8135a2438e 100644 (file)
@@ -1355,7 +1355,7 @@ SYM_FUNC_START(xen_failsafe_callback)
 5:     pushl   $-1                             /* orig_ax = -1 => not a system call */
        SAVE_ALL
        ENCODE_FRAME_POINTER
-       jmp     ret_from_exception
+       jmp     handle_exception_return
 
 .section .fixup, "ax"
 6:     xorl    %eax, %eax
index 2e476f488acef6fe8e91be39108bb5e477056367..a526fb57b65d5190dd0fb5c16eb5e0619de8f427 100644 (file)
@@ -1175,7 +1175,7 @@ SYM_CODE_START(xen_failsafe_callback)
        pushq   $-1 /* orig_ax = -1 => not a system call */
        PUSH_AND_CLEAR_REGS
        ENCODE_FRAME_POINTER
-       jmp     error_exit
+       jmp     error_return
 SYM_CODE_END(xen_failsafe_callback)
 #endif /* CONFIG_XEN_PV */