KVM: x86: Signal #GP, not -EPERM, on bad WRMSR(MCi_CTL/STATUS)

[ Upstream commit b911d7701e27a64d8a30c9bab4974fc21ccf54c7 ]

Return '1', not '-1', when handling an illegal WRMSR to a MCi_CTL or
MCi_STATUS MSR.  The behavior of "all zeros' or "all ones" for CTL MSRs
is architectural, as is the "only zeros" behavior for STATUS MSRs.  I.e.
the intent is to inject a #GP, not exit to userspace due to an unhandled
emulation case.  Returning '-1' gets interpreted as -EPERM up the stack
and effecitvely kills the guest.

Fixes: 5624ec74455f ("KVM: Add MCE support")
Fixes: f143e7d581a8 ("KVM: X86: #GP when guest attempts to write MCi_STATUS register w/o 0")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Link: https://lore.kernel.org/r/20220512222716.4112548-2-seanjc@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index dac2892d095cc3e8f5522bda949c949a74226af4..f5b7a05530eb08dfbfa19e589477a894b8d74cd4 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3109,13 +3109,13 @@ static int set_msr_mce(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
                         */
                        if ((offset & 0x3) == 0 &&
                            data != 0 && (data | (1 << 10) | 1) != ~(u64)0)
-                               return -1;
+                               return 1;
 
                        /* MCi_STATUS */
                        if (!msr_info->host_initiated &&
                            (offset & 0x3) == 1 && data != 0) {
                                if (!can_set_mci_status(vcpu))
-                                       return -1;
+                                       return 1;
                        }
 
                        vcpu->arch.mce_banks[offset] = data;