]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: lan966x: Fix IGMP snooping when frames have vlan tag
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Sat, 9 Apr 2022 18:41:41 +0000 (20:41 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Apr 2022 03:47:15 +0000 (20:47 -0700)
In case an IGMP frame has a vlan tag, then the function
lan966x_hw_offload couldn't figure out that is a IGMP frame. Therefore
the SW thinks that the frame was already forward by the HW which is not
true.
Extend lan966x_hw_offload to pop the vlan tag if are any and then check
for IGMP frames.

Fixes: 95ae38ccac3338 ("net: lan966x: Implement the callback SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED ")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c

index 1f8c67f0261bf8583ef2bd3da425162188034de5..958e55596b823a6403113aa2d2f72f8081a3f73f 100644 (file)
@@ -446,6 +446,12 @@ static bool lan966x_hw_offload(struct lan966x *lan966x, u32 port,
                     ANA_CPU_FWD_CFG_MLD_REDIR_ENA)))
                return true;
 
+       if (eth_type_vlan(skb->protocol)) {
+               skb = skb_vlan_untag(skb);
+               if (unlikely(!skb))
+                       return false;
+       }
+
        if (skb->protocol == htons(ETH_P_IP) &&
            ip_hdr(skb)->protocol == IPPROTO_IGMP)
                return false;