]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: remove lockdep class for DSA master address list
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 10 Feb 2022 13:44:59 +0000 (15:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Feb 2022 11:17:32 +0000 (11:17 +0000)
Since commit 2f1e8ea726e9 ("net: dsa: link interfaces with the DSA
master to get rid of lockdep warnings"), suggested by Cong Wang, the
DSA interfaces and their master have different dev->nested_level, which
makes netif_addr_lock() stop complaining about potentially recursive
locking on the same lock class.

So we no longer need DSA masters to have their own lockdep class.

Cc: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/master.c

index 2199104ca7dfa15f943b24bb3dd52c4e181d33eb..6ac393cc6ea76a449088e5a2e3e2fd4a8f247b73 100644 (file)
@@ -330,8 +330,6 @@ static const struct attribute_group dsa_group = {
        .attrs  = dsa_slave_attrs,
 };
 
-static struct lock_class_key dsa_master_addr_list_lock_key;
-
 int dsa_master_setup(struct net_device *dev, struct dsa_port *cpu_dp)
 {
        struct dsa_switch *ds = cpu_dp->ds;
@@ -353,8 +351,6 @@ int dsa_master_setup(struct net_device *dev, struct dsa_port *cpu_dp)
        wmb();
 
        dev->dsa_ptr = cpu_dp;
-       lockdep_set_class(&dev->addr_list_lock,
-                         &dsa_master_addr_list_lock_key);
 
        dsa_master_set_promiscuity(dev, 1);