powerpc: Fix power4/970 idle code regression with lockdep

in commit 9c090eefaa51b9894cc91191461fe2918095d9db
"powerpc: Rework lazy-interrupt handling"

I introduced a regression, accidentally calling irq tracing twice
and not properly restoring a clobbered register (r7) later used
for writing to the MSR.

This caused lockups when booting on a G5 with lockdep enabled.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

diff --git a/arch/powerpc/kernel/idle_power4.S b/arch/powerpc/kernel/idle_power4.S
index d8cdba4c28b25a7f2c6988414e12e2b3cae7aac0..2c71b0fc9f9101361475e8baaea3136a84753c45 100644 (file)
--- a/arch/powerpc/kernel/idle_power4.S
+++ b/arch/powerpc/kernel/idle_power4.S
@@ -50,9 +50,9 @@ END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP)
        addi    r1,r1,128
        ld      r0,16(r1)
        mtlr    r0
+       mfmsr   r7
 #endif /* CONFIG_TRACE_IRQFLAGS */
 
-       TRACE_ENABLE_INTS
        li      r0,1
        stb     r0,PACASOFTIRQEN(r13)   /* we'll hard-enable shortly */
 BEGIN_FTR_SECTION