]> git.baikalelectronics.ru Git - kernel.git/commitdiff
tls: Fixed uninitialised vars warning
authorVakul Garg <vakul.garg@nxp.com>
Mon, 24 Sep 2018 10:39:49 +0000 (16:09 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Sep 2018 19:24:52 +0000 (12:24 -0700)
In tls_sw_sendmsg() and tls_sw_sendpage(), it is possible that the
uninitialised variable 'ret' gets passed to sk_stream_error(). So
initialise local variable 'ret' to '0. The warnings were detected by
'smatch' tool.

Fixes: b574142da9d5 ("net/tls: Add support for async encryption")
Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c

index d30d65bf0753afc20da5ad55fcc011248ce6ee2b..bf03f32aa9831c6dc012daa4d23606ba639857b2 100644 (file)
@@ -690,7 +690,7 @@ int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
        int record_room;
        int num_zc = 0;
        int orig_size;
-       int ret;
+       int ret = 0;
 
        if (msg->msg_flags & ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL))
                return -ENOTSUPP;
@@ -882,8 +882,8 @@ int tls_sw_sendpage(struct sock *sk, struct page *page,
        int num_async = 0;
        bool full_record;
        int record_room;
+       int ret = 0;
        bool eor;
-       int ret;
 
        if (flags & ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL |
                      MSG_SENDPAGE_NOTLAST))