]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/amd/display: Tune min clk values for MPO for RV
authorPratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Thu, 29 Oct 2020 04:01:00 +0000 (09:31 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 2 Nov 2020 20:32:50 +0000 (15:32 -0500)
[Why]
Incorrect values were resulting in flash lines
when MPO was enabled and system was left idle.

[How]
Increase min clk values only when MPO is enabled
and display is active to not affect S3 power.

Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c

index e133edc587d318098e5576acbff9f30584f8fe68..75b8240ed0595b073af4622a39817e812b81c0c4 100644 (file)
@@ -187,6 +187,17 @@ static void ramp_up_dispclk_with_dpp(
        clk_mgr->base.clks.max_supported_dppclk_khz = new_clocks->max_supported_dppclk_khz;
 }
 
+static bool is_mpo_enabled(struct dc_state *context)
+{
+       int i;
+
+       for (i = 0; i < context->stream_count; i++) {
+               if (context->stream_status[i].plane_count > 1)
+                       return true;
+       }
+       return false;
+}
+
 static void rv1_update_clocks(struct clk_mgr *clk_mgr_base,
                        struct dc_state *context,
                        bool safe_to_lower)
@@ -284,9 +295,22 @@ static void rv1_update_clocks(struct clk_mgr *clk_mgr_base,
                if (pp_smu->set_hard_min_fclk_by_freq &&
                                pp_smu->set_hard_min_dcfclk_by_freq &&
                                pp_smu->set_min_deep_sleep_dcfclk) {
-                       pp_smu->set_hard_min_fclk_by_freq(&pp_smu->pp_smu, new_clocks->fclk_khz / 1000);
-                       pp_smu->set_hard_min_dcfclk_by_freq(&pp_smu->pp_smu, new_clocks->dcfclk_khz / 1000);
-                       pp_smu->set_min_deep_sleep_dcfclk(&pp_smu->pp_smu, (new_clocks->dcfclk_deep_sleep_khz + 999) / 1000);
+                       // Only increase clocks when display is active and MPO is enabled
+                       if (display_count && is_mpo_enabled(context)) {
+                               pp_smu->set_hard_min_fclk_by_freq(&pp_smu->pp_smu,
+                                               ((new_clocks->fclk_khz / 1000) *  101) / 100);
+                               pp_smu->set_hard_min_dcfclk_by_freq(&pp_smu->pp_smu,
+                                               ((new_clocks->dcfclk_khz / 1000) * 101) / 100);
+                               pp_smu->set_min_deep_sleep_dcfclk(&pp_smu->pp_smu,
+                                               (new_clocks->dcfclk_deep_sleep_khz + 999) / 1000);
+                       } else {
+                               pp_smu->set_hard_min_fclk_by_freq(&pp_smu->pp_smu,
+                                               new_clocks->fclk_khz / 1000);
+                               pp_smu->set_hard_min_dcfclk_by_freq(&pp_smu->pp_smu,
+                                               new_clocks->dcfclk_khz / 1000);
+                               pp_smu->set_min_deep_sleep_dcfclk(&pp_smu->pp_smu,
+                                               (new_clocks->dcfclk_deep_sleep_khz + 999) / 1000);
+                       }
                }
        }
 }