]> git.baikalelectronics.ru Git - kernel.git/commitdiff
macsec: fix error message in macsec_add_rxsa and _txsa
authorSabrina Dubroca <sd@queasysnail.net>
Fri, 22 Jul 2022 09:16:28 +0000 (11:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Jul 2022 10:49:25 +0000 (11:49 +0100)
The expected length is MACSEC_SALT_LEN, not MACSEC_SA_ATTR_SALT.

Fixes: bb178617ead6 ("macsec: Netlink support of XPN cipher suites (IEEE 802.1AEbw)")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macsec.c

index 769a1eca6bd8cca683e2b9e27dc61958c3e3dff2..634452d3ecc513a48fb154c7fe5480df4416d8b3 100644 (file)
@@ -1770,7 +1770,7 @@ static int macsec_add_rxsa(struct sk_buff *skb, struct genl_info *info)
                if (nla_len(tb_sa[MACSEC_SA_ATTR_SALT]) != MACSEC_SALT_LEN) {
                        pr_notice("macsec: nl: add_rxsa: bad salt length: %d != %d\n",
                                  nla_len(tb_sa[MACSEC_SA_ATTR_SALT]),
-                                 MACSEC_SA_ATTR_SALT);
+                                 MACSEC_SALT_LEN);
                        rtnl_unlock();
                        return -EINVAL;
                }
@@ -2012,7 +2012,7 @@ static int macsec_add_txsa(struct sk_buff *skb, struct genl_info *info)
                if (nla_len(tb_sa[MACSEC_SA_ATTR_SALT]) != MACSEC_SALT_LEN) {
                        pr_notice("macsec: nl: add_txsa: bad salt length: %d != %d\n",
                                  nla_len(tb_sa[MACSEC_SA_ATTR_SALT]),
-                                 MACSEC_SA_ATTR_SALT);
+                                 MACSEC_SALT_LEN);
                        rtnl_unlock();
                        return -EINVAL;
                }