]> git.baikalelectronics.ru Git - kernel.git/commitdiff
wifi: mwifiex: fix loop iterator in mwifiex_update_ampdu_txwinsize()
authorDan Carpenter <error27@gmail.com>
Mon, 6 Feb 2023 14:41:33 +0000 (17:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:42 +0000 (16:43 +0100)
[ Upstream commit 3cfb7df24cee0f5fdc4cc5d3176cab9aadfcb430 ]

This code re-uses "i" to be the iterator for both the inside and outside
loops.  It means the outside loop will exit earlier than intended.

Fixes: a48f5a543854 ("mwifiex: handle BT coex event to adjust Rx BA window size")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/Y+ERnaDaZD7RtLvX@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/mwifiex/11n.c

index acbef9f1a83b6a298d12869c1cc7a4479219239a..b397a7e85e6b0d2512ee5c52c916efe7d93b6e6f 100644 (file)
@@ -890,7 +890,7 @@ mwifiex_send_delba_txbastream_tbl(struct mwifiex_private *priv, u8 tid)
  */
 void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
 {
-       u8 i;
+       u8 i, j;
        u32 tx_win_size;
        struct mwifiex_private *priv;
 
@@ -921,8 +921,8 @@ void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
                if (tx_win_size != priv->add_ba_param.tx_win_size) {
                        if (!priv->media_connected)
                                continue;
-                       for (i = 0; i < MAX_NUM_TID; i++)
-                               mwifiex_send_delba_txbastream_tbl(priv, i);
+                       for (j = 0; j < MAX_NUM_TID; j++)
+                               mwifiex_send_delba_txbastream_tbl(priv, j);
                }
        }
 }