]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: ethernet: bgmac: Remove unnecessary 'return' from platform_bgmac_idm_write
authorAbhishek Shah <abhishek.shah@broadcom.com>
Thu, 13 Jul 2017 19:04:07 +0000 (00:34 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Jul 2017 21:28:27 +0000 (14:28 -0700)
Return type for idm register write callback should be void as 'writel'
API is used for write operation. However, there no need to have 'return'
in this function.

Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
Reviewed-by: Oza Oza <oza.oza@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bgmac-platform.c

index 73aca97a96bc70fb1e79f04ec2585589d0616cc5..1ca75dea1a77876aa51275272332c6c0cc0a2b6b 100644 (file)
@@ -50,7 +50,7 @@ static u32 platform_bgmac_idm_read(struct bgmac *bgmac, u16 offset)
 
 static void platform_bgmac_idm_write(struct bgmac *bgmac, u16 offset, u32 value)
 {
-       return writel(value, bgmac->plat.idm_base + offset);
+       writel(value, bgmac->plat.idm_base + offset);
 }
 
 static bool platform_bgmac_clk_enabled(struct bgmac *bgmac)