]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: hisi_sas: Increase debugfs_dump_index after dump is completed
authorLuo Jiaxing <luojiaxing@huawei.com>
Tue, 24 Aug 2021 10:01:00 +0000 (18:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 14 Sep 2021 03:56:02 +0000 (23:56 -0400)
The hisi_hba debugfs_dump_index member should increased after a dump
insertion completed, and not before it has started, so fix the code to do
so.

Link: https://lore.kernel.org/r/1629799260-120116-6-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

index cbc6c2d867458f34acc09334b7e53b1b5fe883d6..f4517f3eb92238c5fb3611868578b155346eb7d1 100644 (file)
@@ -3688,7 +3688,6 @@ static void debugfs_snapshot_regs_v3_hw(struct hisi_hba *hisi_hba)
 
        do_div(timestamp, NSEC_PER_MSEC);
        hisi_hba->debugfs_timestamp[debugfs_dump_index] = timestamp;
-       hisi_hba->debugfs_dump_index++;
 
        debugfs_snapshot_prepare_v3_hw(hisi_hba);
 
@@ -3704,6 +3703,7 @@ static void debugfs_snapshot_regs_v3_hw(struct hisi_hba *hisi_hba)
        debugfs_create_files_v3_hw(hisi_hba);
 
        debugfs_snapshot_restore_v3_hw(hisi_hba);
+       hisi_hba->debugfs_dump_index++;
 }
 
 static ssize_t debugfs_trigger_dump_v3_hw_write(struct file *file,