]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: lan743x: Use correct variable in lan743x_sgmii_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 23 Jun 2022 13:34:03 +0000 (16:34 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 24 Jun 2022 18:19:29 +0000 (11:19 -0700)
There is a copy and paste bug in lan743x_sgmii_config() so it checks
if (ret < 0) instead of if (mii_ctl < 0).

Fixes: f16abd441749 ("net: lan743x: Add support to SGMII 1G and 2.5G")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/YrRry7K66BzKezl8@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan743x_main.c

index 79ecf296161ea37a51c5b37cb28650246bcf2603..a9a1dea6d7311104ed2d9d2fc4eaea43a5838e4d 100644 (file)
@@ -1212,8 +1212,8 @@ static int lan743x_sgmii_config(struct lan743x_adapter *adapter)
 
        /* SGMII/1000/2500BASE-X PCS power down */
        mii_ctl = lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR);
-       if (ret < 0)
-               return ret;
+       if (mii_ctl < 0)
+               return mii_ctl;
 
        mii_ctl |= BMCR_PDOWN;
        ret = lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl);