]> git.baikalelectronics.ru Git - kernel.git/commitdiff
media: doc: Document dual use of H.264 pic_num/frame_num
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Tue, 26 Apr 2022 12:57:27 +0000 (14:57 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 13 May 2022 12:58:29 +0000 (14:58 +0200)
These two fields need documentation as they have dual meaning. It is also
confusing since pic_num is a derived value from frame_num, so this should
help application developers. If we ever need to make a V2 of this API, I
would suggest to remove pic_num entirely.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst

index 6541e4c32b26a5d9448cf7baac5b0c151e386709..bee73065e993159824b9aff410f04e7636698cae 100644 (file)
@@ -649,10 +649,16 @@ Stateless Codec Control ID
         :c:type:`timeval` in struct :c:type:`v4l2_buffer` to a __u64.
     * - __u32
       - ``pic_num``
-      -
+      - For short term references, this must match the derived value PicNum
+       (8-28) and for long term references it must match the derived value
+       LongTermPicNum (8-29). When decoding frames (as opposed to fields)
+       pic_num is the same as FrameNumWrap.
     * - __u16
       - ``frame_num``
-      -
+      - For short term references, this must match the frame_num value from
+       the slice header syntax (the driver will wrap the value if needed). For
+       long term references, this must be set to the value of
+       long_term_frame_idx described in the dec_ref_pic_marking() syntax.
     * - __u8
       - ``fields``
       - Specifies how the DPB entry is referenced. See :ref:`Reference Fields <h264_ref_fields>`