]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: remove obsolete comments about switchdev transactions
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sat, 9 Jan 2021 00:01:54 +0000 (02:01 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Jan 2021 00:00:57 +0000 (16:00 -0800)
Now that all port object notifiers were converted to be non-transactional,
we can remove the comments that say otherwise.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/slave.c
net/dsa/switch.c

index 7ba505825db2f6301162754908394913baaacb00..5d7f6cada6a81bc1138cbdf5b397f72f9588d56e 100644 (file)
@@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev,
        struct dsa_port *dp = dsa_slave_to_port(dev);
        int err;
 
-       /* For the prepare phase, ensure the full set of changes is feasable in
-        * one go in order to signal a failure properly. If an operation is not
-        * supported, return -EOPNOTSUPP.
-        */
-
        switch (obj->id) {
        case SWITCHDEV_OBJ_ID_PORT_MDB:
                if (obj->orig_dev != dev)
index f92eaacb17cfe58933840ba41bc359de05069d55..21d2f842d068fb8b0746db8e16f65eeed35d1172 100644 (file)
@@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb,
                break;
        }
 
-       /* Non-switchdev operations cannot be rolled back. If a DSA driver
-        * returns an error during the chained call, switch chips may be in an
-        * inconsistent state.
-        */
        if (err)
                dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
                        event, err);