]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/i915: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 14:52:29 +0000 (17:52 +0300)
committerJani Nikula <jani.nikula@intel.com>
Mon, 17 Jun 2019 12:53:08 +0000 (15:53 +0300)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613145229.21389-1-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_debugfs.c

index 2bddb3dd2bf5e7182615938ecbcfabbf45063956..62cf34db9280b20e4c43e405d3ff56468eb26198 100644 (file)
@@ -4444,23 +4444,17 @@ static const struct i915_debugfs_files {
 int i915_debugfs_register(struct drm_i915_private *dev_priv)
 {
        struct drm_minor *minor = dev_priv->drm.primary;
-       struct dentry *ent;
        int i;
 
-       ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
-                                 minor->debugfs_root, to_i915(minor->dev),
-                                 &i915_forcewake_fops);
-       if (!ent)
-               return -ENOMEM;
+       debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
+                           to_i915(minor->dev), &i915_forcewake_fops);
 
        for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
-               ent = debugfs_create_file(i915_debugfs_files[i].name,
-                                         S_IRUGO | S_IWUSR,
-                                         minor->debugfs_root,
-                                         to_i915(minor->dev),
-                                         i915_debugfs_files[i].fops);
-               if (!ent)
-                       return -ENOMEM;
+               debugfs_create_file(i915_debugfs_files[i].name,
+                                   S_IRUGO | S_IWUSR,
+                                   minor->debugfs_root,
+                                   to_i915(minor->dev),
+                                   i915_debugfs_files[i].fops);
        }
 
        return drm_debugfs_create_files(i915_debugfs_list,