net: bridge: use switchdev for port flags set through sysfs too

Looking through patchwork I don't see that there was any consensus to
use switchdev notifiers only in case of netlink provided port flags but
not sysfs (as a sort of deprecation, punishment or anything like that),
so we should probably keep the user interface consistent in terms of
functionality.

http://patchwork.ozlabs.org/project/netdev/patch/20170605092043.3523-3-jiri@resnulli.us/
http://patchwork.ozlabs.org/project/netdev/patch/20170608064428.4785-3-jiri@resnulli.us/

Fixes: 3cccb5d07e11 ("net: bridge: Add support for offloading port attributes")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
index 96ff63cde1beb194a1788d11d38b494f7d1374a5..5aea9427ffe1b2f645f8e37eb28ae698a41e212b 100644 (file)
--- a/net/bridge/br_sysfs_if.c
+++ b/net/bridge/br_sysfs_if.c
@@ -59,9 +59,8 @@ static BRPORT_ATTR(_name, 0644,                                       \
 static int store_flag(struct net_bridge_port *p, unsigned long v,
                      unsigned long mask)
 {
-       unsigned long flags;
-
-       flags = p->flags;
+       unsigned long flags = p->flags;
+       int err;
 
        if (v)
                flags |= mask;
@@ -69,6 +68,10 @@ static int store_flag(struct net_bridge_port *p, unsigned long v,
                flags &= ~mask;
 
        if (flags != p->flags) {
+               err = br_switchdev_set_port_flag(p, flags, mask);
+               if (err)
+                       return err;
+
                p->flags = flags;
                br_port_flags_change(p, mask);
        }