]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: lpfc: Remove redundant lpfc_sli_prep_wqe() call
authorJames Smart <jsmart2021@gmail.com>
Wed, 27 Apr 2022 22:22:23 +0000 (15:22 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 2 May 2022 20:59:11 +0000 (16:59 -0400)
Prior patch added a call to lpfc_sli_prep_wqe() prior to
lpfc_sli_issue_iocb().  This call should not have been added as prep_wqe is
called within the issue_iocb routine. So it's called twice now.

Remove the redundant prep call.

Link: https://lore.kernel.org/r/20220427222223.57920-1-jsmart2021@gmail.com
Fixes: 94fb1a2fd0f2 ("scsi: lpfc: SLI path split: Refactor Abort paths")
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c

index e8c31c080ef306ad8b9e4bc0c3f84415a9628de2..aba06794146d76784dd6853e189134ceced2dbee 100644 (file)
@@ -18689,13 +18689,11 @@ lpfc_sli4_seq_abort_rsp(struct lpfc_vport *vport,
               phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
        bf_set(wqe_cmnd, &icmd->generic.wqe_com, CMD_XMIT_BLS_RSP64_CX);
 
-
        /* Xmit CT abts response on exchange <xid> */
        lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
                         "1200 Send BLS cmd x%x on oxid x%x Data: x%x\n",
                         ctiocb->abort_rctl, oxid, phba->link_state);
 
-       lpfc_sli_prep_wqe(phba, ctiocb);
        rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, ctiocb, 0);
        if (rc == IOCB_ERROR) {
                lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT,