]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ipv6: fix panic when forwarding a pkt with no in6 dev
authorNicolas Dichtel <nicolas.dichtel@6wind.com>
Fri, 8 Apr 2022 14:03:42 +0000 (16:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Apr 2022 11:28:43 +0000 (12:28 +0100)
kongweibin reported a kernel panic in ip6_forward() when input interface
has no in6 dev associated.

The following tc commands were used to reproduce this panic:
tc qdisc del dev vxlan100 root
tc qdisc add dev vxlan100 root netem corrupt 5%

CC: stable@vger.kernel.org
Fixes: 5ff89b510dac ("ipv6: fix 'disable_policy' for fwd packets")
Reported-by: kongweibin <kongweibin2@huawei.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_output.c

index e23f058166af582af3adf9ce1267286cf334ff7b..fa63ef2bd99cca97aff455d4b39d267f69365b35 100644 (file)
@@ -485,7 +485,7 @@ int ip6_forward(struct sk_buff *skb)
                goto drop;
 
        if (!net->ipv6.devconf_all->disable_policy &&
-           !idev->cnf.disable_policy &&
+           (!idev || !idev->cnf.disable_policy) &&
            !xfrm6_policy_check(NULL, XFRM_POLICY_FWD, skb)) {
                __IP6_INC_STATS(net, idev, IPSTATS_MIB_INDISCARDS);
                goto drop;