]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: pm8001: Remove local variable in pm8001_pci_resume()
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sun, 20 Feb 2022 03:17:52 +0000 (12:17 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Feb 2022 02:31:18 +0000 (21:31 -0500)
In pm8001_pci_resume(), the use of the u32 type for the local variable
device_state causes a sparse warning:

warning: incorrect type in assignment (different base types)
    expected unsigned int [usertype] device_state
    got restricted pci_power_t [usertype] current_state

Since this variable is used only once in the function, remove it and use
pdev->current_state directly. While at it, also add a blank line after the
last local variable declaration.

Link: https://lore.kernel.org/r/20220220031810.738362-14-damien.lemoal@opensource.wdc.com
Reviewed-by: John Garry <john.garry@huawei.com>
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c

index d7b95ad4533e71eb71ac1f50ce896ed2476bce90..3811052869538ce9674134c455db09c8c6568072 100644 (file)
@@ -1336,13 +1336,13 @@ static int __maybe_unused pm8001_pci_resume(struct device *dev)
        struct pm8001_hba_info *pm8001_ha;
        int rc;
        u8 i = 0, j;
-       u32 device_state;
        DECLARE_COMPLETION_ONSTACK(completion);
+
        pm8001_ha = sha->lldd_ha;
-       device_state = pdev->current_state;
 
-       pm8001_info(pm8001_ha, "pdev=0x%p, slot=%s, resuming from previous operating state [D%d]\n",
-                     pdev, pm8001_ha->name, device_state);
+       pm8001_info(pm8001_ha,
+                   "pdev=0x%p, slot=%s, resuming from previous operating state [D%d]\n",
+                   pdev, pm8001_ha->name, pdev->current_state);
 
        rc = pci_go_44(pdev);
        if (rc)