]> git.baikalelectronics.ru Git - kernel.git/commitdiff
irqchip/irq-mvebu-gicp: Fix refcount leak in mvebu_gicp_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 2 Jan 2023 08:42:08 +0000 (12:42 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:40 +0000 (16:43 +0100)
[ Upstream commit 9419e700021a393f67be36abd0c4f3acc6139041 ]

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: b39f5e95dfd5 ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230102084208.3951758-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-mvebu-gicp.c

index 3be5c5dba1dab0a503b07dd3274d9eebbeabf5aa..5caec411059f53d4318e3d4b1523d54cd34c1efb 100644 (file)
@@ -223,6 +223,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
        }
 
        parent_domain = irq_find_host(irq_parent_dn);
+       of_node_put(irq_parent_dn);
        if (!parent_domain) {
                dev_err(&pdev->dev, "failed to find parent IRQ domain\n");
                return -ENODEV;