]> git.baikalelectronics.ru Git - kernel.git/commitdiff
powerpc/ptdump: Fix display of RW pages on FSL_BOOK3E
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Tue, 28 Jun 2022 14:43:35 +0000 (16:43 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 29 Jun 2022 07:03:42 +0000 (17:03 +1000)
On FSL_BOOK3E, _PAGE_RW is defined with two bits, one for user and one
for supervisor. As soon as one of the two bits is set, the page has
to be display as RW. But the way it is implemented today requires both
bits to be set in order to display it as RW.

Instead of display RW when _PAGE_RW bits are set and R otherwise,
reverse the logic and display R when _PAGE_RW bits are all 0 and
RW otherwise.

This change has no impact on other platforms as _PAGE_RW is a single
bit on all of them.

Fixes: 0796cc493713 ("powerpc/mm: Dump linux pagetables")
Cc: stable@vger.kernel.org
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/0c33b96317811edf691e81698aaee8fa45ec3449.1656427391.git.christophe.leroy@csgroup.eu
arch/powerpc/mm/ptdump/shared.c

index 03607ab90c66f79606f0f0b2a216b9fc387138e1..f884760ca5cfe3dfbad2d5c441eeeade0279f72f 100644 (file)
@@ -17,9 +17,9 @@ static const struct flag_info flag_array[] = {
                .clear  = "    ",
        }, {
                .mask   = _PAGE_RW,
-               .val    = _PAGE_RW,
-               .set    = "rw",
-               .clear  = "r ",
+               .val    = 0,
+               .set    = "r ",
+               .clear  = "rw",
        }, {
                .mask   = _PAGE_EXEC,
                .val    = _PAGE_EXEC,