]> git.baikalelectronics.ru Git - kernel.git/commitdiff
MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu
authorMenglong Dong <dong.menglong@zte.com.cn>
Mon, 11 Jan 2021 13:27:25 +0000 (05:27 -0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Wed, 13 Jan 2021 09:59:32 +0000 (10:59 +0100)
The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
can't be true.

Fix this by change the type of 'r' and 'i' from 'unsigned int'
to 'int'. As 'i' won't be negative, this change works.

Fixes: 99fbc70f8547 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ")
Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/cavium-octeon/octeon-irq.c

index bd47e15d02c73ea599e896a197500896ee7c174a..be5d4afcd30f930e6eb828d55a05099be8402a5d 100644 (file)
@@ -1444,7 +1444,7 @@ static void octeon_irq_setup_secondary_ciu2(void)
 static int __init octeon_irq_init_ciu(
        struct device_node *ciu_node, struct device_node *parent)
 {
-       unsigned int i, r;
+       int i, r;
        struct irq_chip *chip;
        struct irq_chip *chip_edge;
        struct irq_chip *chip_mbox;