]> git.baikalelectronics.ru Git - kernel.git/commitdiff
watchdog: keembay: Update pretimeout to zero in the TH ISR
authorShruthi Sanil <shruthi.sanil@intel.com>
Mon, 17 May 2021 17:49:47 +0000 (23:19 +0530)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 21 Jun 2021 06:48:54 +0000 (08:48 +0200)
The pretimeout has to be updated to zero during the ISR of the
ThresHold interrupt. Else the TH interrupt would be triggerred for
every tick until the timeout.

Fixes: 65392bb2ca8c ("watchdog: Add watchdog driver for Intel Keembay Soc")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Kris Pan <kris.pan@intel.com>
Signed-off-by: Shruthi Sanil <shruthi.sanil@intel.com>
Link: https://lore.kernel.org/r/20210517174953.19404-4-shruthi.sanil@intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/keembay_wdt.c

index b2afeb4a60e3325fbb13a15eb178ff1ec6c90161..6053416b8d3d48b4414fc571e1af45ab064a01d5 100644 (file)
@@ -154,6 +154,8 @@ static irqreturn_t keembay_wdt_th_isr(int irq, void *dev_id)
        struct keembay_wdt *wdt = dev_id;
        struct arm_smccc_res res;
 
+       keembay_wdt_set_pretimeout(&wdt->wdd, 0x0);
+
        arm_smccc_smc(WDT_ISR_CLEAR, WDT_ISR_MASK, 0, 0, 0, 0, 0, 0, &res);
        dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt pre-timeout.\n");
        watchdog_notify_pretimeout(&wdt->wdd);