]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: ipa: fix page free in ipa_endpoint_replenish_one()
authorAlex Elder <elder@linaro.org>
Thu, 26 May 2022 15:23:14 +0000 (10:23 -0500)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 May 2022 01:29:50 +0000 (18:29 -0700)
Currently the (possibly compound) pages used for receive buffers are
freed using __free_pages().  But according to this comment above the
definition of that function, that's wrong:
    If you want to use the page's reference count to decide
    when to free the allocation, you should allocate a compound
    page, and use put_page() instead of __free_pages().

Convert the call to __free_pages() in ipa_endpoint_replenish_one()
to use put_page() instead.

Fixes: 7db6548cd0dad ("net: ipa: allocate transaction in replenish loop")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_endpoint.c

index e92aa9447f6e7b3f4fc6669368c844b9681778c8..d3b3255ac3d1210597a579b0a31ff83831c73e28 100644 (file)
@@ -1095,7 +1095,7 @@ static int ipa_endpoint_replenish_one(struct ipa_endpoint *endpoint,
 
        ret = gsi_trans_page_add(trans, page, len, offset);
        if (ret)
-               __free_pages(page, get_order(buffer_size));
+               put_page(page);
        else
                trans->data = page;     /* transaction owns page now */