wifi: wilc1000: set station_info flag only when signal value is valid

Set station_info->filled to indicate signal level only when its value is
received successfully using wilc_get_rssi().

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220720160302.231516-4-ajay.kathat@microchip.com

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
index 5c2c7f1dbffdd727f4b56a5d97930dd254c7ee32..3ac373d29d9368e08bdf4f0b07edb03b9f560c1d 100644 (file)
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -1312,12 +1312,11 @@ static int dump_station(struct wiphy *wiphy, struct net_device *dev,
        if (idx != 0)
                return -ENOENT;
 
-       sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL);
-
        ret = wilc_get_rssi(vif, &sinfo->signal);
        if (ret)
                return ret;
 
+       sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL);
        memcpy(mac, vif->priv.associated_bss, ETH_ALEN);
        return 0;
 }