]> git.baikalelectronics.ru Git - kernel.git/commitdiff
mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources_register
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 20 Mar 2020 02:16:38 +0000 (19:16 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2020 03:57:16 +0000 (20:57 -0700)
When building arm32 allyesconfig:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by spectrum_cnt.c
>>>               net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>> did you mean: __aeabi_uidivmod
>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)

pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
do not error.

Fixes: 49cf58ff4391 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c

index 0268f0a6662aca6393104559926c6827bc4a2ebe..7974982533b541ae7e96607713197f2ed698a79f 100644 (file)
@@ -303,7 +303,7 @@ int mlxsw_sp_counter_resources_register(struct mlxsw_core *mlxsw_core)
        }
 
        /* Check config is valid, no bank over subscription */
-       if (WARN_ON(total_bank_config > pool_size / bank_size + 1))
+       if (WARN_ON(total_bank_config > div64_u64(pool_size, bank_size) + 1))
                return -EINVAL;
 
        return 0;