]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ipmi/watchdog: replace atomic_add() and atomic_sub()
authorYejune Deng <yejune.deng@gmail.com>
Mon, 16 Nov 2020 07:30:07 +0000 (15:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2023 07:32:52 +0000 (08:32 +0100)
commit 970c9ec29a27b22b33c402f5d4fd62133d9899ac upstream.

atomic_inc() and atomic_dec() looks better

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Message-Id: <1605511807-7135-1-git-send-email-yejune.deng@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmi_watchdog.c

index 72ad7fff64a7ac0f4bb8eb44518b2ccc924e919c..5fd78274931109c1966e9eaf6cba0da28c0f6565 100644 (file)
@@ -498,7 +498,7 @@ static void panic_halt_ipmi_heartbeat(void)
        msg.cmd = IPMI_WDOG_RESET_TIMER;
        msg.data = NULL;
        msg.data_len = 0;
-       atomic_add(1, &panic_done_count);
+       atomic_inc(&panic_done_count);
        rv = ipmi_request_supply_msgs(watchdog_user,
                                      (struct ipmi_addr *) &addr,
                                      0,
@@ -508,7 +508,7 @@ static void panic_halt_ipmi_heartbeat(void)
                                      &panic_halt_heartbeat_recv_msg,
                                      1);
        if (rv)
-               atomic_sub(1, &panic_done_count);
+               atomic_dec(&panic_done_count);
 }
 
 static struct ipmi_smi_msg panic_halt_smi_msg = {
@@ -532,12 +532,12 @@ static void panic_halt_ipmi_set_timeout(void)
        /* Wait for the messages to be free. */
        while (atomic_read(&panic_done_count) != 0)
                ipmi_poll_interface(watchdog_user);
-       atomic_add(1, &panic_done_count);
+       atomic_inc(&panic_done_count);
        rv = __ipmi_set_timeout(&panic_halt_smi_msg,
                                &panic_halt_recv_msg,
                                &send_heartbeat_now);
        if (rv) {
-               atomic_sub(1, &panic_done_count);
+               atomic_dec(&panic_done_count);
                pr_warn("Unable to extend the watchdog timeout\n");
        } else {
                if (send_heartbeat_now)