]> git.baikalelectronics.ru Git - kernel.git/commitdiff
mptcp: Fix duplicated argument in protocol.h
authorWan Jiabing <wanjiabing@vivo.com>
Wed, 1 Sep 2021 03:19:32 +0000 (11:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Sep 2021 11:51:48 +0000 (12:51 +0100)
Fix the following coccicheck warning:
./net/mptcp/protocol.h:36:50-73: duplicated argument to & or |

The OPTION_MPTCP_MPJ_SYNACK here is duplicate.
Here should be OPTION_MPTCP_MPJ_ACK.

Fixes: 74c7dfbee3e18 ("mptcp: consolidate in_opt sub-options fields in a bitmask")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.h

index d7aba1c4dc484eb6d4cda5756a8b13549a5f8e1b..64c9a30e087193501c0c0ef257bc621f8e9544a8 100644 (file)
@@ -34,7 +34,7 @@
 #define OPTIONS_MPTCP_MPC      (OPTION_MPTCP_MPC_SYN | OPTION_MPTCP_MPC_SYNACK | \
                                 OPTION_MPTCP_MPC_ACK)
 #define OPTIONS_MPTCP_MPJ      (OPTION_MPTCP_MPJ_SYN | OPTION_MPTCP_MPJ_SYNACK | \
-                                OPTION_MPTCP_MPJ_SYNACK)
+                                OPTION_MPTCP_MPJ_ACK)
 
 /* MPTCP option subtypes */
 #define MPTCPOPT_MP_CAPABLE    0