]> git.baikalelectronics.ru Git - kernel.git/commitdiff
bus: ti-sysc: Use fsleep() instead of usleep_range() in sysc_reset()
authorJulien Panis <jpanis@baylibre.com>
Mon, 21 Aug 2023 14:24:18 +0000 (16:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Oct 2023 12:56:46 +0000 (14:56 +0200)
[ Upstream commit d929b2b7464f95ec01e47f560b1e687482ba8929 ]

The am335x-evm started producing boot errors because of subtle timing
changes:

Unhandled fault: external abort on non-linefetch (0x1008) at 0xf03c1010
...
sysc_reset from sysc_probe+0xf60/0x1514
sysc_probe from platform_probe+0x5c/0xbc
...

The fix consists in using the appropriate sleep function in sysc reset.
For flexible sleeping, fsleep is recommended. Here, sysc delay parameter
can take any value in [0 - 255] us range. As a result, fsleep() should
be used, calling udelay() for a sysc delay lower than 10 us.

Signed-off-by: Julien Panis <jpanis@baylibre.com>
Fixes: e709ed70d122 ("bus: ti-sysc: Fix missing reset delay handling")
Message-ID: <20230821-fix-ti-sysc-reset-v1-1-5a0a5d8fae55@baylibre.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bus/ti-sysc.c

index ddde1427c90c7891be5147ded6204d85ac2bcd0b..6ac79417b5120a525ead7ea5808e4718a36006cf 100644 (file)
@@ -2166,8 +2166,7 @@ static int sysc_reset(struct sysc *ddata)
        }
 
        if (ddata->cfg.srst_udelay)
-               usleep_range(ddata->cfg.srst_udelay,
-                            ddata->cfg.srst_udelay * 2);
+               fsleep(ddata->cfg.srst_udelay);
 
        if (ddata->post_reset_quirk)
                ddata->post_reset_quirk(ddata);