]> git.baikalelectronics.ru Git - kernel.git/commitdiff
parisc: Fix mask used to select futex spinlock
authorJohn David Anglin <dave.anglin@bell.net>
Tue, 21 Dec 2021 18:33:16 +0000 (13:33 -0500)
committerHelge Deller <deller@gmx.de>
Tue, 21 Dec 2021 20:15:59 +0000 (21:15 +0100)
The address bits used to select the futex spinlock need to match those used in
the LWS code in syscall.S. The mask 0x3f8 only selects 7 bits.  It should
select 8 bits.

This change fixes the glibc nptl/tst-cond24 and nptl/tst-cond25 tests.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
Fixes: f4d3d83e4f55 ("parisc: Switch to more fine grained lws locks")
Cc: stable@vger.kernel.org # 5.10+
Signed-off-by: Helge Deller <deller@gmx.de>
arch/parisc/include/asm/futex.h

index 70cf8f0a7617b3465324e6eeceabb48503852781..9cd4dd6e63ad9dc578721add9beebbc9ccacd9cd 100644 (file)
@@ -14,7 +14,7 @@ static inline void
 _futex_spin_lock(u32 __user *uaddr)
 {
        extern u32 lws_lock_start[];
-       long index = ((long)uaddr & 0x3f8) >> 1;
+       long index = ((long)uaddr & 0x7f8) >> 1;
        arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
        preempt_disable();
        arch_spin_lock(s);
@@ -24,7 +24,7 @@ static inline void
 _futex_spin_unlock(u32 __user *uaddr)
 {
        extern u32 lws_lock_start[];
-       long index = ((long)uaddr & 0x3f8) >> 1;
+       long index = ((long)uaddr & 0x7f8) >> 1;
        arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
        arch_spin_unlock(s);
        preempt_enable();