KVM: SVM: Introduce trace point for the slow-path of avic_kic_target_vcpus

This can help identify potential performance issues when handles
AVIC incomplete IPI due vCPU not running.

Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20220420154954.19305-3-suravee.suthikulpanit@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
index 7249d766519f49ee07debf106392c31e551467c8..54fe03714f8a6af9cc929f595d2f0b2ff86cb439 100644 (file)
--- a/arch/x86/kvm/svm/avic.c
+++ b/arch/x86/kvm/svm/avic.c
@@ -354,6 +354,8 @@ static void avic_kick_target_vcpus(struct kvm *kvm, struct kvm_lapic *source,
        if (!avic_kick_target_vcpus_fast(kvm, source, icrl, icrh, index))
                return;
 
+       trace_kvm_avic_kick_vcpu_slowpath(icrh, icrl, index);
+
        /*
         * Wake any target vCPUs that are blocking, i.e. waiting for a wake
         * event.  There's no need to signal doorbells, as hardware has handled

diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
index e3a24b8f04be83d4425956567ddfc36593bbaf1c..de47625175692d2a158a01be381a4358fdef510a 100644 (file)
--- a/arch/x86/kvm/trace.h
+++ b/arch/x86/kvm/trace.h
@@ -1459,6 +1459,26 @@ TRACE_EVENT(kvm_avic_ga_log,
                  __entry->vmid, __entry->vcpuid)
 );
 
+TRACE_EVENT(kvm_avic_kick_vcpu_slowpath,
+           TP_PROTO(u32 icrh, u32 icrl, u32 index),
+           TP_ARGS(icrh, icrl, index),
+
+       TP_STRUCT__entry(
+               __field(u32, icrh)
+               __field(u32, icrl)
+               __field(u32, index)
+       ),
+
+       TP_fast_assign(
+               __entry->icrh = icrh;
+               __entry->icrl = icrl;
+               __entry->index = index;
+       ),
+
+       TP_printk("icrh:icrl=%#08x:%08x, index=%u",
+                 __entry->icrh, __entry->icrl, __entry->index)
+);
+
 TRACE_EVENT(kvm_hv_timer_state,
                TP_PROTO(unsigned int vcpu_id, unsigned int hv_timer_in_use),
                TP_ARGS(vcpu_id, hv_timer_in_use),

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index ee774c734066e94af8c117ed75266e137b9d041f..1abce22b14d77ffb8722329e98b87e2021b44906 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -13072,6 +13072,7 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_pi_irte_update);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_avic_unaccelerated_access);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_avic_incomplete_ipi);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_avic_ga_log);
+EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_avic_kick_vcpu_slowpath);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_apicv_accept_irq);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_vmgexit_enter);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_vmgexit_exit);