]> git.baikalelectronics.ru Git - kernel.git/commitdiff
powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 3 Jun 2022 12:15:42 +0000 (16:15 +0400)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 1 Aug 2022 12:21:18 +0000 (22:21 +1000)
of_find_node_by_path() returns remote device nodepointer with
refcount incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: ea5362f56619 ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220603121543.22884-1-linmq006@gmail.com
arch/powerpc/platforms/cell/spufs/inode.c

index 34334c32b7f58c09ad2fa49cffb5a27e28450894..320008528edd96d5f9cb25c03fe390ff131e78c7 100644 (file)
@@ -660,6 +660,7 @@ spufs_init_isolated_loader(void)
                return;
 
        loader = of_get_property(dn, "loader", &size);
+       of_node_put(dn);
        if (!loader)
                return;