ssb: Remove redundant assignment to err

Variable 'err' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Clean up the following clang-analyzer warning:

drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]
drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 0e180c36daa4112c4bca11744b136df3a0c7dfab..620cc9dccad796d5fcc0cd7777326b436387a5f1 100644 (file)
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1312,13 +1312,11 @@ static int __init ssb_modinit(void)
        if (err) {
                pr_err("Broadcom 43xx PCI-SSB-bridge initialization failed\n");
                /* don't fail SSB init because of this */
-               err = 0;
        }
        err = ssb_host_pcmcia_init();
        if (err) {
                pr_err("PCMCIA host initialization failed\n");
                /* don't fail SSB init because of this */
-               err = 0;
        }
        err = ssb_gige_init();
        if (err) {