powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address

[ Upstream commit 070c2e437c1f0beed845123afd5613e5d21aaf04 ]

of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: 532ae9ce60f7 ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
index 82335e364c440705d5b1c00ed6b2d00e84edd8e0..f630693c8de72f6bee28d3a7c6785ecc65992bcd 100644 (file)
--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -226,6 +226,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
        if (!prop) {
                dev_dbg(&dev->dev,
                        "axon_msi: no msi-address-(32|64) properties found\n");
+               of_node_put(dn);
                return -ENOENT;
        }