]> git.baikalelectronics.ru Git - kernel.git/commitdiff
lockd: Update the NLMv4 SHARE results encoder to use struct xdr_stream
authorChuck Lever <chuck.lever@oracle.com>
Thu, 3 Jun 2021 20:53:29 +0000 (16:53 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 7 Jul 2021 00:14:44 +0000 (20:14 -0400)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/lockd/xdr4.c

index efdede71b9511f54865f90d8c9a99e17ee1a5809..98e957e4566c27f8a6e91d0ae73711c461572d57 100644 (file)
@@ -40,15 +40,6 @@ loff_t_to_s64(loff_t offset)
        return res;
 }
 
-static __be32 *
-nlm4_encode_cookie(__be32 *p, struct nlm_cookie *c)
-{
-       *p++ = htonl(c->len);
-       memcpy(p, c->data, c->len);
-       p+=XDR_QUADLEN(c->len);
-       return p;
-}
-
 /*
  * NLM file handles are defined by specification to be a variable-length
  * XDR opaque no longer than 1024 bytes. However, this implementation
@@ -356,11 +347,16 @@ nlm4svc_encode_res(struct svc_rqst *rqstp, __be32 *p)
 int
 nlm4svc_encode_shareres(struct svc_rqst *rqstp, __be32 *p)
 {
+       struct xdr_stream *xdr = &rqstp->rq_res_stream;
        struct nlm_res *resp = rqstp->rq_resp;
 
-       if (!(p = nlm4_encode_cookie(p, &resp->cookie)))
+       if (!svcxdr_encode_cookie(xdr, &resp->cookie))
                return 0;
-       *p++ = resp->status;
-       *p++ = xdr_zero;                /* sequence argument */
-       return xdr_ressize_check(rqstp, p);
+       if (!svcxdr_encode_stats(xdr, resp->status))
+               return 0;
+       /* sequence */
+       if (xdr_stream_encode_u32(xdr, 0) < 0)
+               return 0;
+
+       return 1;
 }